Skip to content

Commit

Permalink
chore: fix typos
Browse files Browse the repository at this point in the history
Signed-off-by: snoppy <[email protected]>
  • Loading branch information
xiaoxianBoy committed Apr 19, 2024
1 parent 7ac17c8 commit 058f485
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/starkware/algebra/fft/multiplicative_group_ordering.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ namespace starkware {
For our purpose the interesting ones are NaturalOrder - [1, w, w^2, w^3, ...] and
BitReversedOrder [1, -1, w^{N/4}, -w^{N/4} ...] = [w^{bitrev(0)}, w^{bitrev(1)},w^{ bitrev(2), ..]
Diffrent FFT implementations have diffrent ordering requirements on the polynomial evaluations.
Different FFT implementations have different ordering requirements on the polynomial evaluations.
This enum can be used to indicate which one is expected.
Note that a polynomial evaluation is the output of and FFT and the input to the IFFT.
Since in-place radix2 fft implemenations have the side effect of BitReversal Permuation,
Since in-place radix2 fft implemenations have the side effect of BitReversal Permutation,
The order of polynomial coefficents (== ifft output) will typically be the mirror order
to the order of the evaluation.
However in some cases we might prefer some other ordering, so one should look at the specific
Expand Down
2 changes: 1 addition & 1 deletion src/third_party/poseidon/poseidon.c
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ void permutation_3_montgomery(felt_t state_in_montgomery_form[]) {
}

// Convert the state to reduced Montgomery form. If this is not done, values who are permutated
// multiple times might become numericly unstable and overflow from 256-bit, hence the transform
// multiple times might become numerically unstable and overflow from 256-bit, hence the transform
// to the minimal representative.
for (i = 0; i < 3; i++) {
f251_final_reduce(state_in_montgomery_form[i], state_in_montgomery_form[i]);
Expand Down

0 comments on commit 058f485

Please sign in to comment.