added deprecation to impl #7257
Conversation
|
This change is |
dean-starkware
force-pushed
the
dean/deprecated_trait_items
branch
from
990151a to
5a00d55
Compare
There was a problem hiding this comment.
Reviewed 2 of 12 files at r1, all commit messages.
Reviewable status: 2 of 12 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
-- commits line 5 at r1:
fix rebase.
There was a problem hiding this comment.
Reviewable status: 2 of 12 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)
Previously, orizi wrote…
fix rebase.
what's the problem?
it's on top of the trait's PR.
There was a problem hiding this comment.
Reviewable status: 2 of 12 files reviewed, 1 unresolved discussion (waiting on @dean-starkware and @gilbens-starkware)
Previously, dean-starkware wrote…
what's the problem?
it's on top of the trait's PR.
so i should see only the changes from it. after merge rebase. or before merge - change target.
(but since just merged - just rebase)
There was a problem hiding this comment.
Reviewable status: 2 of 12 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)
Previously, orizi wrote…
so i should see only the changes from it. after merge rebase. or before merge - change target.
(but since just merged - just rebase)
It is the target though.
Everything seems right.
Anyway- I'll rebase with main once it's merged and change the target to main.
There was a problem hiding this comment.
Reviewable status: 2 of 12 files reviewed, 1 unresolved discussion (waiting on @dean-starkware and @gilbens-starkware)
Previously, dean-starkware wrote…
It is the target though.
Everything seems right.
Anyway- I'll rebase with main once it's merged and change the target to main.
still awaiting on rebase - please only respond after.
dean-starkware
changed the base branch from
dean/deprecated_trait_items
to
main
dean-starkware
force-pushed
the
dean/deprecated_impl
branch
from
6f3bfe2 to
8dda338
Compare
There was a problem hiding this comment.
Reviewed 1 of 12 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
No description provided.