Made sure closure type isn't var free if it captured vars. #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
force-pushed
the
orizi/fix-missing-closure-rewrites
branch
2 times, most recently
from
23118f3 to
1f30768
Compare
TomerStarkware
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
orizi
force-pushed
the
orizi/fix-missing-closure-rewrites
branch
2 times, most recently
from
275cf12 to
1178311
Compare
orizi
force-pushed
the
orizi/fix-missing-closure-rewrites
branch
from
1178311 to
83eefb0
Compare
orizi
commented
Feb 10, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)
orizi
commented
Feb 10, 2025
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.