-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Lib Documentation: Vec
module
#7025
Conversation
This reverts commit a5d18b1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TAdev0)
corelib/src/starknet/storage/vec.cairo
line 28 at r2 (raw file):
//! //! // Read element (returns Option) //! let value = self.my_vec.get(0).unwrap_or(0).read();
unwrap_or can't work here - as the returned value is an entry, not a value (that can be 0)
Code quote:
//! let value = self.my_vec.get(0).unwrap_or(0).read();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/starknet/storage/vec.cairo
line 28 at r2 (raw file):
Previously, orizi wrote…
unwrap_or can't work here - as the returned value is an entry, not a value (that can be 0)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TAdev0)
No description provided.