Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update range.cairo #6988

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update range.cairo #6988

wants to merge 2 commits into from

Conversation

Dahka2321
Copy link

Add PartialEq to the derive attributes for the RangeIterator struct to maintain consistency with the Range struct implementation and enable equality comparisons between RangeIterator instances.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"consistency with the Range struct" not sure about at all.

can you give an expected use case for this?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@Dahka2321
Copy link
Author

The PartialEq trait was added to maintain consistency because:

  1. The Range struct already implements PartialEq, allowing for equality comparisons
  2. RangeIterator is closely related to Range and should support similar operations
  3. This enables users to compare RangeIterator instances when needed, just like they can with Range

@Dahka2321 Dahka2321 requested a review from orizi January 8, 2025 16:07
@Dahka2321
Copy link
Author

@orizi

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Dahka2321)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Dahka2321)


a discussion (no related file):
@gilbens-starkware for 2nd eye.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Dahka2321)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants