Fix merge fragments #711
Merged
Fix merge fragments #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #709 in which
data-signalswas being reapplied each time any attribute changed on an element, caused by the fact that it doesn’t return a cleanup function so a hash was never created for it – a real headfuck to debug.The fix includes storing an empty cleanup function for plugins that don’t return one. It also rehashes the cleanup functions for each element being merged to ensure that plugins are cleaned up and reapplied after merging.
I’ve also restored the assigning of unique element IDs to fragments being merged, to allow focus to be restored to focusable elements, which fixes #710.
@delaneyj note that I changed the
removalskey from an element to an element ID to allow for rehashing in themergeFragmentsplugin.