No longer run callable on init #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delaneyj
approved these changes
Feb 25, 2025
bencroker
added a commit
that referenced
this pull request
Feb 25, 2025
* A typo in getting_started.md (#673) Closing tag for the data-computed example has an extra ">" * Clojure sdk: Fixes, clojure snippets (#672) * Clojure sdk: Fixes, new website snippets Docs: corrected the readme's example Fix: changed return value in the jetty implementation Chore: Changed dependency coordinate of http-kit to a newer maven dependency Fix: using setTimeout in the redirect sugar function Fix: mistake in http-kit management in examples Docs: redirect example Feature: added another testing utility Docs: added missing snippets for the Datastar website * Fix: typo * Fix code samples [deploy-site] * Maintain whitespace (#678) * Fix #677 [deploy-site] * Better fix [deploy-site] * feat(SDK): FastHTML SSE response and example (#576) (#624) * feat(SDK): FastHTML SSE response and example (#576) * feat(sdk): add simple fasthtml example * remove comments --------- Co-authored-by: Lucian Knock <[email protected]> * Improve wording * Fix text overflow on buttons (#681) [deploy-site] * JavaScript * Fix example link * Add `develop` branch * Add checkbox value behaviour based on signal type (#674) * Modify checkbox and radio behaviour * Add array and string types * Move code into block * Refactor and add tests * Add release note * DatastarNaN added to datastar elements without ids (#684) * Default to element value using `data-bind` (#687) * Default to element value using `data-bind` * Fix tests * Destructure result * Destructure again * Add release note * Test command runs unit tests only (#689) * Test command runs unit tests only * Update paths in action * Enforce branch policy * Add passing check * Add new docs for `data-bind` * Update branch policy * Fix and add tests * Debounce applying plugins on page load (#690) * Debounce applying plugins on page load * Fix action * Update Idiomorph to 0.7.2 (#688) * Update to 0.7.2 * Fix indicator and remove auto ID generation * Ensure plugins not reapplied (#691) * Update to 0.7.2 * Fix indicator and remove auto ID generation * Setup * Data-* attributes hash their contents * Update release notes * Revert star.ts and remove test --------- Co-authored-by: Delaney Gillilan <[email protected]> * Fix `data-attr` not removing element attribute (#697) * Fix `data-attr` not removing element attribute * Typo * Add `aliased` test * Typescript sdk improvements (#698) * improvements to node sdk Add abort handling to node sdk, make onError simpler and close stream by default - closes #667 - closes #602 * Improvements to typescript sdk readme Ben Croker wanted a mergeSignals example * Make typescript sdk pass tests * add missing typescript snippets and use same name as sdk folder * update datastar version in typescript sdk test servers * Refactor SDK snippets and add title * 699-Replace-legacy-call-to-`applyAttributePlugin` (#701) * Replace legacy call to `applyAttributePlugin` Fixes #699 * Ignore when alias prefix missing * Remove merge fragment callbacks * add bundler support --------- Co-authored-by: Ben Croker <[email protected]> * 695-Embrace-our-functional-overlords (#702) * Replace legacy call to `applyAttributePlugin` Fixes #699 * Ignore when alias prefix missing * Remove merge fragment callbacks * add bundler support * Embrace our functional overlords Fixes #695 * change to djb2 hash * Replace reference page * Add reference docs pages --------- Co-authored-by: Ben Croker <[email protected]> * No longer run callable on init (#703) * No longer run callable on init * Add release note * Document alias and remove `prefix` (#704) * Document alias and remove `prefix` * Remove example * Order independent testing (#593) * normalize output and test output and then compare * separate ordered data lines from unordered data lines + only remove space after colon if its after a key at the beginning of the line * don't remove space after colon * only sort unordered fields * update readme * add gitignore to sdk/.test folder * Document SSE events Fixes #581 * fix sdk npm package (#705) * v1.0.0-beta.8 --------- Co-authored-by: Claes Ström <[email protected]> Co-authored-by: Jérémy <[email protected]> Co-authored-by: Lucian <[email protected]> Co-authored-by: Lucian Knock <[email protected]> Co-authored-by: Akash Gill <[email protected]> Co-authored-by: Delaney <[email protected]> Co-authored-by: Patrick Marchand <[email protected]> Co-authored-by: Johnathan Stevers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes running the callable on page load when using
data-on-signals-change.This is an alternative to #692. Fixes #682.