Fixes #682

starfederation · Feb 22, 2025 · cb6dcba · cb6dcba
1 parent 0c085c3
commit cb6dcba
Show file tree

Hide file tree

Showing 9 changed files with 36 additions and 37 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,4 +20,4 @@ Each tagged version of Datastar is accompanied by a release note. Read the [rele
 
 - Fixed a bug in which `datastar-remove-fragments` events were not having any effect ([#664](https://github.com/starfederation/datastar/issues/664)).
 - Fixed a bug in which `datastarNaN` could be used as an auto-generated element ID ([#679](https://github.com/starfederation/datastar/issues/679)).
-- Fixed a bug in which plugins were being applied to the DOM twice on page load.
+- Fixed a bug in which the expression passed into `data-on-signals-change` was being called each time the attribute was evaluated ([#682](https://github.com/starfederation/datastar/issues/682)).
diff --git a/bundles/datastar-aliased.js b/bundles/datastar-aliased.js
diff --git a/bundles/datastar-aliased.js.map b/bundles/datastar-aliased.js.map
diff --git a/bundles/datastar-core.js b/bundles/datastar-core.js
diff --git a/bundles/datastar-core.js.map b/bundles/datastar-core.js.map
diff --git a/bundles/datastar.js b/bundles/datastar.js
diff --git a/bundles/datastar.js.map b/bundles/datastar.js.map
diff --git a/library/src/plugins/official/dom/attributes/on.ts b/library/src/plugins/official/dom/attributes/on.ts
@@ -121,7 +121,6 @@ export const On: AttributePlugin = {
 
     if (key.startsWith(SIGNALS_CHANGE_PREFIX)) {
       if (key === SIGNALS_CHANGE_PREFIX) {
-        callback()
         const signalFn = (event: CustomEvent<DatastarSignalEvent>) =>
           callback(event)
         document.addEventListener(DATASTAR_SIGNAL_EVENT, signalFn)

diff --git a/sdk/go/consts.go b/sdk/go/consts.go