Revert star.ts and remove test

starfederation · Feb 22, 2025 · a047ec3 · a047ec3
1 parent 5d42472
commit a047ec3
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 47 deletions.
diff --git a/bundles/datastar-aliased.js b/bundles/datastar-aliased.js
diff --git a/bundles/datastar-aliased.js.map b/bundles/datastar-aliased.js.map
diff --git a/bundles/datastar-core.js b/bundles/datastar-core.js
diff --git a/bundles/datastar-core.js.map b/bundles/datastar-core.js.map
diff --git a/bundles/datastar.js b/bundles/datastar.js
diff --git a/bundles/datastar.js.map b/bundles/datastar.js.map
diff --git a/library/src/plugins/official/core/attributes/star.ts b/library/src/plugins/official/core/attributes/star.ts
@@ -9,9 +9,7 @@ export const Star: AttributePlugin = {
   name: 'star',
   keyReq: Requirement.Denied,
   valReq: Requirement.Denied,
-  onLoad: ({ signals }) => {
-    //alert('YOU ARE PROBABLY OVERCOMPLICATING IT')
-    const value = signals.signal('result')?.value as number
-    signals.setValue('result', value + 1)
+  onLoad: () => {
+    alert('YOU ARE PROBABLY OVERCOMPLICATING IT')
   },
 }
diff --git a/sdk/go/consts.go b/sdk/go/consts.go
diff --git a/site/routes_tests.go b/site/routes_tests.go
@@ -40,7 +40,6 @@ func setupTests(ctx context.Context, router chi.Router) (err error) {
 				{ID: "merge_fragment_signal"},
 				{ID: "merge_fragment_whitespace"},
 				{ID: "on_load"},
-				{ID: "plugin_applied_once"},
 				{ID: "radio_input"},
 				{ID: "ref"},
 				{ID: "remove_fragment"},

diff --git a/site/smoketests/plugin_applied_once_test.go b/site/smoketests/plugin_applied_once_test.go
diff --git a/site/static/md/tests/plugin_applied_once.md b/site/static/md/tests/plugin_applied_once.md