Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking compatibility with Python 3.8 #452

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix breaking compatibility with Python 3.8 #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
335c13b
Fix breaking compatibility with Python 3.8
damian3031 Nov 26, 2024
403a246
Fix test_run_hooks tests
damian3031 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20241126-125237.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: Fix breaking compatibility with Python 3.8
time: 2024-11-26T12:52:37.426245+01:00
custom:
Author: damian3031
Issue: ""
PR: "452"
4 changes: 2 additions & 2 deletions dbt/adapters/trino/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from dataclasses import dataclass
from typing import Dict, Optional
from typing import Dict, List, Optional

import agate
from dbt.adapters.base.impl import AdapterConfig, ConstraintSupport
Expand Down Expand Up @@ -53,7 +53,7 @@ def __init__(self, config, mp_context) -> None:
self.connections = self.ConnectionManager(config, mp_context, self.behavior)

@property
def _behavior_flags(self) -> list[BehaviorFlag]:
def _behavior_flags(self) -> List[BehaviorFlag]:
return [
{ # type: ignore
"name": "require_certificate_validation",
Expand Down
4 changes: 1 addition & 3 deletions tests/functional/adapter/hooks/test_run_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
BaseAfterRunHooks,
BasePrePostRunHooks,
)
from dbt.tests.util import run_dbt


class TestPrePostRunHooksTrino(BasePrePostRunHooks):
Expand Down Expand Up @@ -55,5 +54,4 @@ def check_hooks(self, state, project, host):


class TestAfterRunHooksTrino(BaseAfterRunHooks):
def test_missing_column_pre_hook(self, project):
run_dbt(["run"], expect_pass=False)
pass
Loading