Skip to content

Commit

Permalink
Merge pull request #34 from starburstdata/hovaesco/release-1.0.1
Browse files Browse the repository at this point in the history
Release 1.0.1
  • Loading branch information
hovaesco authored Jan 24, 2022
2 parents a28f666 + b825fa1 commit d2dbf79
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .bumpversion-dbt.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.0.0
current_version = 1.0.1
parse = (?P<major>\d+)
\.(?P<minor>\d+)
\.(?P<patch>\d+)
Expand Down
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.0.0
current_version = 1.0.1
parse = (?P<major>\d+)
\.(?P<minor>\d+)
\.(?P<patch>\d+)
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ dbt-trino-tests:
./docker/dbt/build.sh
./docker/init_trino.bash
pip install -r dev_requirements.txt
tox || ./docker/remove_trino.bash
tox -r || ./docker/remove_trino.bash
./docker/remove_trino.bash

dbt-starburst-tests:
docker network create dbt-net || true
./docker/dbt/build.sh
./docker/init_starburst.bash
pip install -r dev_requirements.txt
tox || ./docker/remove_starburst.bash
tox -r || ./docker/remove_starburst.bash
./docker/remove_starburst.bash
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This repository represents a fork of the [dbt-presto](https://github.com/dbt-lab

### Compatibility

This dbt plugin has been tested against `Trino` version `366` and `Starburst Enterprise` version `365-e`.
This dbt plugin has been tested against `Trino` version `368` and `Starburst Enterprise` version `368-e`.

## Installation

Expand Down Expand Up @@ -265,7 +265,7 @@ pip install -r dev_requirements.txt
Run from the base directory of the project the command:

```sh
tox
tox -r
```

or
Expand All @@ -284,8 +284,6 @@ bumpversion --config-file .bumpversion-dbt.cfg patch --new-version <new-version>
bumpversion --config-file .bumpversion.cfg patch --new-version <new-version> --allow-dirty
```

Additionally bump dbt-core version in dbt testing image `docker/dbt/Dockerfile`.

Next step is to merge bump commit and making sure that test suite pass.

Finally to release `dbt-trino` to PyPi and GitHub trigger release workflow `release.yml`.
Expand Down
2 changes: 1 addition & 1 deletion dbt/adapters/trino/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version = "1.0.0"
version = "1.0.1"
2 changes: 1 addition & 1 deletion docker-compose-starburst.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
trino:
ports:
- "8080:8080"
image: "starburstdata/starburst-enterprise:365-e"
image: "starburstdata/starburst-enterprise:368-e"
volumes:
- ./docker/starburst/etc:/etc/starburst
- ./docker/starburst/catalog:/etc/starburst/catalog
Expand Down
2 changes: 1 addition & 1 deletion docker-compose-trino.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
trino:
ports:
- "8080:8080"
image: "trinodb/trino:366"
image: "trinodb/trino:368"
volumes:
- ./docker/trino/etc:/usr/lib/trino/etc:ro
- ./docker/trino/catalog:/etc/trino/catalog
Expand Down
2 changes: 1 addition & 1 deletion docker/dbt/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM fishtownanalytics/dbt:1.0.0
FROM python:3.9.9-slim-bullseye
USER root

ENV DBT_DIR /opt/dbt-trino
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dbt-core==1.0.0
dbt-core==1.0.1
trino==0.309.0
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _dbt_trino_version():
package_version = _dbt_trino_version()
description = """The trino adapter plugin for dbt (data build tool)"""

dbt_version = "1.0.0"
dbt_version = "1.0.1"
# the package version should be the dbt version, with maybe some things on the
# ends of it. (0.19.1 vs 0.19.1a1, 0.19.1.1, ...)
if not package_version.startswith(dbt_version):
Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _get_tester_for(self, column_type):
return agate.TimeDelta()

for instance in agate_helper.DEFAULT_TYPE_TESTER._possible_types:
if type(instance) is column_type:
if isinstance(instance, column_type):
return instance

raise ValueError(f"no tester for {column_type}")
Expand Down

0 comments on commit d2dbf79

Please sign in to comment.