Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin python 3.12 for publishing #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philvarner
Copy link
Contributor

@philvarner philvarner commented Jan 29, 2025

Related Issue(s):

  • n/a

Proposed Changes:

  1. The default python for gitlab changed to 3.13 recently, so the build-package in python-publish.yml gitlab command now fails because of the 3.12 constraint on the package. Explicitly pinning the publish to 3.12, with the expectation we will update to support 3.13 sometime soon.

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@trevorskaggs
Copy link

Do we need a ticket for the 3.13 upgrade? Otherwise this looks good to go!

@jkeifer
Copy link
Member

jkeifer commented Jan 29, 2025

I'd actually go the other way around on this and fix the pinning and add testing for 3.13. @pjhartzell already did this as part of #132. The strict pinning on 3.12 was, I believe, the result of miscommunication at the last STAPI sprint, not an intentional limitation restricting this package to 3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants