-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix certain iOS editors failing to load and save note content #42
Conversation
Co-authored-by: Mo Bitar <[email protected]>
Co-authored-by: Johnny A. <[email protected]>
I'm not sure if the comment should be changed now as well since we will no longer be simply taking the first event that comes. Would you agree? |
Co-authored-by: Seb <[email protected]>
Hmm tests are failing for me locally now. @SebTota can you run the tests locally to see if the same? |
@mobitar Sorry, I didn't have a chance to test locally yet with all the new changes. I just tested now, and it seems like the I did ignore the failed tests and built anyway and the changes do seem to fix the problem on iOS. I also tested with Bold Editor just to make sure nothing broke and it works well. |
From a quick glance, this might be the problem. |
@mobitar Please check my most recent commit on my repo. I'm unsure of how to reopen this PR to add the commit. Update: This fixes the unit tests. Essentially, you always had duplicate events firing in your unit tests but since |
You'd just open another PR with these changes 👍 |
Reference Issue: #15