fix: update API paths to use API domain #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
approved these changes
Jan 5, 2024
Set blockstackAPIUrl to coreApiUrl to ensure tests are run against the correct endpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 57.55% 57.42% -0.14%
==========================================
Files 8 8
Lines 761 761
==========================================
- Hits 438 437 -1
- Misses 323 324 +1 ☔ View full report in Codecov by Sentry. |
|
@jcnelson Fixed! |
wileyj
reviewed
Jan 9, 2024
| @@ -9,6 +9,7 @@ import { StacksMainnet } from '@stacks/network' | |||
| nock.disableNetConnect() | |||
|
|
|||
| bskConfig.network = new StacksMainnet() | |||
| bskConfig.network.blockstackAPIUrl = bskConfig.network.coreApiUrl | |||
There was a problem hiding this comment.
wouldn't this be easy to change the env var to STACKS_API_URL etc, vs continuing to use the BLOCKSTACK_API_URL?
There was a problem hiding this comment.
Maybe, but it's not a high enough priority for us to invest more resources in at the moment.
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates any endpoints which use a Stacks Blockchain API path to call the correctly configured endpoint for the service. Previously, this bug was hidden because the Stacks Blockchain API and Stacks Core RPC service had to be configured on the same domain. Now that they can be configured on separate domains since release 1.3.0, this bug popped up.
I've deployed and tested this patch and it appears to be running the same as it were at version 1.2.1.