Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap_comments = true #5789

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: wrap_comments = true #5789

wants to merge 1 commit into from

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jan 31, 2025

I opened this so we could take a look at the results and discuss if we want to do something more consistent than what we do currently. It is not smart enough to just merge this PR unfortunately, as it does some dumb things with spacing.

The problem I am trying to solve is that some places we wrap at column 80, some wrap at 100, some at 120, some never. There is not much consistency.

@obycode obycode requested review from a team as code owners January 31, 2025 20:27
@jbencin
Copy link
Contributor

jbencin commented Jan 31, 2025

A couple comments:

  • I think we should set comment_width to greater than 80 (like 120?). We have plenty of lines of code longer than 80 chars, and it would result in a smaller diff
  • This should be set in rustfmt.toml. The fmt-stacks alias only exists because those specific options only work from the command line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants