Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/vrf seed in get sortition rpc endpoint #5772

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feat/vrf seed in get sortition rpc endpoint #5772

wants to merge 5 commits into from
+26 −3

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Jan 30, 2025 •
edited
Loading

Description

WIP

Add vrf-seed in /v3/sortitions

Applicable issues

Additional info (benefits, drawbacks, caveats)

This endpoint is used in clarinet in a new feature that allows to simulate transactions on mainnet.
The vrf-seed is the only missing data

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@hugocaillard hugocaillard changed the base branch from master to develop January 30, 2025 13:50
kantai
kantai reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks like the right approach to me!

jcnelson
jcnelson reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right approach, but please add some unit test coverage in stackslib/src/net/api/tests/getsortition.rs.

@hugocaillard hugocaillard marked this pull request as ready for review February 4, 2025 18:17
@hugocaillard hugocaillard requested review from a team as code owners February 4, 2025 18:17
obycode
obycode reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry to the Changelog?

@hugocaillard hugocaillard requested a review from a team as a code owner February 4, 2025 22:11
@hugocaillard hugocaillard requested a review from obycode February 4, 2025 22:12
@hugocaillard
Copy link
Collaborator Author

Done @obycode, thx

obycode
obycode approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode approved these changes

@kantai kantai Awaiting requested review from kantai

@jcnelson jcnelson Awaiting requested review from jcnelson

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add vrf-seed to /v3/sortitions
4 participants
@hugocaillard @jcnelson @kantai @obycode