Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clippy lints approx_constant, assertions_on_constants, assign_op_pattern, and bool_assert_comparison #5745

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Apply clippy lints approx_constant, assertions_on_constants, assign_op_pattern, and bool_assert_comparison #5745

wants to merge 5 commits into from

Conversation

jferrant
Copy link
Collaborator

No description provided.

@jferrant
Fix approx_constant, assertions_on_constants, assign_op_pattern, and …
832d561 
…bool_assert_comparison throughout stacks-core

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested review from a team as code owners January 24, 2025 22:36
jbencin
jbencin previously approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some style suggestions but everything looks correct

@jbencin jbencin added the lint Related to linting/clippy/cargo warns label Jan 28, 2025
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
272dd27 
… into chore/clippy-assertions-assign-op-approx-constant
@jferrant
Code review comments
32ca6e5 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested a review from jbencin January 29, 2025 20:47
@jferrant
Code review comments part 2
0903fdd 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
bbfc775 
… into chore/clippy-assertions-assign-op-approx-constant
obycode
obycode reviewed Jan 31, 2025
View reviewed changes
stackslib/src/net/dns.rs
client.try_recv().unwrap();
let resolved_err = client.poll_lookup("www.google.com", 80).unwrap().unwrap();
assert!(
format!("{resolved_err:?}").find("timed out").is_some(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
format!("{resolved_err:?}").find("timed out").is_some(),
format!("{resolved_err:?}").contains("timed out"),

obycode
obycode reviewed Jan 31, 2025
View reviewed changes
testnet/stacks-node/src/tests/neon_integrations.rs
@@ -3,7 +3,7 @@ use std::path::{Path, PathBuf};
use std::sync::atomic::{AtomicU64, Ordering};
use std::sync::{mpsc, Arc};
use std::time::{Duration, Instant};
use std::{cmp, env, fs, io, thread};
use std::{cmp, env, fs, io, panic, thread};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

obycode
obycode reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had 2 minor comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode left review comments

@jbencin jbencin jbencin approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

@hstove hstove Awaiting requested review from hstove

@kantai kantai Awaiting requested review from kantai

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
lint Related to linting/clippy/cargo warns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jferrant @obycode @jbencin