-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI update #18
base: main
Are you sure you want to change the base?
CLI update #18
Conversation
@@ -0,0 +1,55 @@ | |||
name: version, tag and github release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wileyj the oclif generate ..
command used to update the CLI libraries added these release automation workflows. The code looks fine to me, but some repo secrets need to be added for it to work. Thoughts?
@@ -0,0 +1,21 @@ | |||
name: publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wileyj same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests! 👏
@@ -0,0 +1,7 @@ | |||
#!/usr/bin/env node | |||
|
|||
// eslint-disable-next-line unicorn/prefer-top-level-await |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄
This tool was using a several year old version of
oclif
(the CLI library that this tool is built on) which was issuing several warnings when using the tool.This PR updates to latest
oclif
version. Their tooling added some release automation which needs testing.