Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add workflow for lints #144

Merged
merged 3 commits into from
May 13, 2024
Merged

CI: add workflow for lints #144

merged 3 commits into from
May 13, 2024

Conversation

netrome
Copy link
Contributor

@netrome netrome commented May 13, 2024

closes #143

@netrome netrome self-assigned this May 13, 2024
@netrome netrome linked an issue May 13, 2024 that may be closed by this pull request
CI: Add workflow for lints #143
Closed
8marz8
8marz8 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@8marz8 8marz8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AshtonStephens
Copy link
Collaborator

AshtonStephens commented May 13, 2024 •
edited
Loading

Can we make this a step or part of the unit test workflow? It feels like the CI is duplicating work unnecessarily

I'm wondering about the reasoning behind this choice. I recognize it's better not to muddy different workflows with different kinds of data but I bet there's a way to do some of this processing only once and still keep the errors clear.

@netrome
Copy link
Contributor Author

netrome commented May 13, 2024

Can we make this a step or part of the unit test workflow? It feels like the CI is duplicating work unnecessarily

I'm wondering about the reasoning behind this choice. I recognize it's better not to muddy different workflows with different kinds of data but I bet there's a way to do some of this processing only once and still keep the errors clear.

Sure thing, I think that makes sense. I'll update.

@netrome
Copy link
Contributor Author

netrome commented May 13, 2024 •
edited
Loading

Can we make this a step or part of the unit test workflow? It feels like the CI is duplicating work unnecessarily

I'm wondering about the reasoning behind this choice. I recognize it's better not to muddy different workflows with different kinds of data but I bet there's a way to do some of this processing only once and still keep the errors clear.

Updated. The PR is super tiny now ;)

@netrome netrome merged commit 2bc7674 into main May 13, 2024
3 checks passed
@cylewitruk cylewitruk deleted the 143-ci-add-workflow-for-lints branch February 2, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8marz8 8marz8 8marz8 approved these changes

@AshtonStephens AshtonStephens AshtonStephens approved these changes

@djordon djordon Awaiting requested review from djordon

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Add workflow for lints
3 participants
@netrome @AshtonStephens @8marz8