-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: wsts-related cleanup #1287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of quick questions, but LGTM
@xoloki is the wsts version/rev correct? |
This is the rev for the head of the apply-fix branch, which has all the hotfixes plus the framework necessary for this PR. I'm really not sure what version this should be. That branch is still version |
Yeah we might need a minor release to include that, if we don't want to use the commit hash. I've reviewed the changes so I'm fine with using the commit hash until it's ready, but yeah it would be nice to have a |
Ok, I'll publish |
Description
A breakout PR from #1285 to move some of the more refactor-like changes related to WSTS.
Part of: #1300
main
.Changes
WstsMessage.txid
toid
and use aWstsMessageId
enum instead of abitcoin::Txid
.txid
field (flagging thisbreaking-protocol
anyway, just in-case).StateMachineId
is now an enum instead of a newtype over[u8; 32]
.wsts_state_machine.rs
. This is the bulk of the changes in this PRwsts
to this commit (apply-fix
+ this).Testing Information
All existing tests pass and devenv works like a charm.
Checklist: