[feat]: print signer version and pubkey on startup #1279
Conversation
| "starting the sBTC signer", | ||
| ); | ||
|
|
||
| // Load the configuration file and/or environment variables. | ||
| let settings = Settings::new(args.config)?; | ||
|
|
||
| tracing::info!( | ||
| signer_public_key = %PublicKey::from_private_key(&settings.signer.private_key), |
There was a problem hiding this comment.
I think I would just add this to the above startup log fields tbh, we don't really need to explicitly know that the config has been loaded successfully because it will exit with an error if it fails.
There was a problem hiding this comment.
Than we want to create settings before writing that first log line. If you think it will be better I don't mind we can do it
There was a problem hiding this comment.
Having the above log before the config creation makes sense to me -- we are sure we get some logs in case there were bad issues with the config itself.
I'm fine with having this log on a different logline, but I would:
- add a method in
SignerConfigreturning the public key, and call it here - change the message from
constructed signer settingsto something more tailored to the public key
| @@ -74,11 +75,18 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| revision = signer::GIT_COMMIT, | |||
| arch = signer::TARGET_ARCH, | |||
| env_abi = signer::TARGET_ENV_ABI, | |||
| signer_version = signer::VERSION, | |||
There was a problem hiding this comment.
I don't think we are actively using the package version (I guess revision is already enough)
| "starting the sBTC signer", | ||
| ); | ||
|
|
||
| // Load the configuration file and/or environment variables. | ||
| let settings = Settings::new(args.config)?; | ||
|
|
||
| tracing::info!( | ||
| signer_public_key = %PublicKey::from_private_key(&settings.signer.private_key), |
There was a problem hiding this comment.
Having the above log before the config creation makes sense to me -- we are sure we get some logs in case there were bad issues with the config itself.
I'm fine with having this log on a different logline, but I would:
- add a method in
SignerConfigreturning the public key, and call it here - change the message from
constructed signer settingsto something more tailored to the public key
Description
This PR changes signer binary such that it prints signer version and pubkey to logs on startup
Closes: #1106
Changes
Added few log lines
Testing Information
I think testing here is not worth the effort, so just tried to run this locally
Checklist: