Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wsts 12 #1265

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update to wsts 12 #1265

wants to merge 4 commits into from

Conversation

xoloki
Copy link
Collaborator

@xoloki xoloki commented Jan 24, 2025

Description

Update the wsts dependency to 12.0.0

Closes #1162, closes #1166, and closes #1167

Changes

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@xoloki xoloki requested a review from djordon January 24, 2025 14:58
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@matteojug matteojug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sBTC side:

WSTS side:

  1. in check_public_shares: maybe switch the order of the checks (first len, then verify)? I'm not sure if verify does something bad if the poly len is wrong
  2. make_shared_secret_from_key (calling ansi_x963_derive_key) generates a different key now because of the counter and the order of hash updates, is it fine (wrt backward compatibility with data already generated)? Does this makes this a breaking protocol change (ie, if signers are running different versions can they still interact as expected)?
  3. maybe nit: fn gen<RNG: RngCore + CryptoRng>(rng: &mut RNG) -> Scalar: as this don’t use a secret, doing the generation as in 4.1 (see comment) doesn’t seem to give any better guarantees: if the rng is a bad one, this will still generate bad nonces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants