refactor: pass around block refs #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
1152-load-aggregate-key-dependent-signer-state-machines
to
main
January 16, 2025 02:59
djordon
changed the base branch from
main
to
1152-load-aggregate-key-dependent-signer-state-machines
block ref from the database
djordon
force-pushed
the
refactor-pass-block-refs
branch
from
da4e9f3 to
3f87d31
Compare
Base automatically changed from
1152-load-aggregate-key-dependent-signer-state-machines
to
main
January 16, 2025 03:01
4 tasks
djordon
requested review from
matteojug,
AshtonStephens,
Jiloc,
cylewitruk and
MCJOHN974
and removed request for
AshtonStephens
djordon
modified the milestones:
sBTC: Withdrawal Minimum Working Flow,
sBTC: Key rotation
cylewitruk
reviewed
Jan 21, 2025
There was a problem hiding this comment.
You know, I was actually thinking about this when doing the info endpoint since I wanted something that returned both the canonical hash/height, but opted to keep it simple and do an extra call.
What I was thinking would that it would be best if methods took an AsRef<BitcoinBlockHash> that need a block hash and we implemented that for BitcoinBlockRef and get_canonical_bitcoin_chain_tip() returns one too.
Thoughts?
MCJOHN974
reviewed
Jan 21, 2025
matteojug
reviewed
Jan 27, 2025
matteojug
reviewed
Feb 4, 2025
with outdated chain tips
matteojug
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
transaction_signermodule to expect aBitcoinBlockRef.Testing Information
This is a refactor, so if tests pass then we should be good.
Checklist: