-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Reject duplicate deposit requests when first one already accepted | confirmed | failed #1179
Conversation
@matteojug is it correct that we want to reject deposits not only if they are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the Emily side of things @MCJOHN974 ! I left a few comments about changes required to handle duplicates deposits in all statuses
Thanks @matteojug and @Jiloc for your comments, I think last few commits contain your suggestions |
Description
Closes: #1161
Changes
Now
create_deposit
requests returns 409 (Conflict) if we already have same deposit acceptedTesting Information
Added integration test for this.
Locally I run it the following way:
Checklist: