Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

Fix broken tests and CI #60

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fix broken tests and CI #60

merged 4 commits into from
Oct 8, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented Oct 8, 2024

This PR fixes the broken CI in the trusty action by introducing two changes:

  1. When setting up go, we now use the version used in go.mod
  2. It fixes some outdated tests to ensure they pass again. This is a temporary fix while we migrate the action to the new API client (see note on b8384af )

Supersedes #59

Signed-off-by: Adolfo García Veytia (puerco) [email protected]

dependabot bot and others added 4 commits October 8, 2024 19:41
Bumps the actions group with 2 updates in the / directory: [actions/checkout](https://github.com/actions/checkout) and [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action).


Updates `actions/checkout` from 4.2.0 to 4.2.1
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@d632683...eef6144)

Updates `aquasecurity/trivy-action` from 0.24.0 to 0.25.0
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@6e7b7d1...f781cce)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
This imports github.com/stretchr/testify to start updating the tests in the action code.

Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
This updates some of the broken tests so that they pass again. Some
of the tests were looking for outdated data and will be replaced in
an upcoming rewrite of the API libraries.

Consider this as a temporary measure to regain signal on testing
while we migrate the API.

Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of b8384afb:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Copy link

@therealnb therealnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@puerco puerco merged commit 13ff5ce into stacklok:main Oct 8, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants