cherry-pick: common: Stop using transitional labels to fix config-diff
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stop using the old config name (td-agent.conf) Change-Id: Ied2736b891cd8c6dfcc509a8fd6b1fc8bfe21cb4
|
Sounds like we need this to unblock config diff, this seems important. Upstream discussion is on going here: (obviously, we need to add local config gen into kolla-ansible CI upstream) |
JohnGarbutt
approved these changes
Jan 16, 2025
assumptionsandg
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Have also hit this issue: https://gitlab.developers.cam.ac.uk/rcs/platforms/cloud-services/arcus-kayobe-config/-/jobs/2082163
Alex-Welsh
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error would occur in task
Ensure fluentd image is present for label checkduring aconfig-diff.This happened due to the task attempting to pull the
fluentdimage whichconfig-diffcould not perform.Fortunately the offending task has been removed in
kolla/ansible@master.With this patch
config-diffis functional again withinCaracalAlso stop using the old config name (td-agent.conf)
Change-Id: Ied2736b891cd8c6dfcc509a8fd6b1fc8bfe21cb4