Merge pull request #42 from stackhpc/fix-httpboot-templating

Fix leading and trailing whitespace in inspection_callback_url
stackhpc · Nov 28, 2024 · e41e109 · e41e109
2 parents 6d70418 + b354d95
commit e41e109
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/playbooks/roles/bifrost-ironic-install/tasks/create_tftpboot.yml b/playbooks/roles/bifrost-ironic-install/tasks/create_tftpboot.yml
@@ -184,8 +184,8 @@
     mode: "0644"
   vars:
     inspection_callback_url: >-
-      {% if enable_inspector | bool %}
+      {%- if enable_inspector | bool -%}
       {{ api_protocol }}://{{ internal_ip }}:5050/v1/continue
-      {% else %}
+      {%- else -%}
       {{ api_protocol }}://{{ internal_ip }}:6385/v1/continue_inspection
-      {% endif %}
+      {%- endif -%}
diff --git a/releasenotes/notes/fix-whitespace-in-inspection-callback-3f450db7ae2c91d5.yaml b/releasenotes/notes/fix-whitespace-in-inspection-callback-3f450db7ae2c91d5.yaml
@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    Fixes an issue where ``inspection_callback_url`` was templated with leading
+    whitespace. This caused the ``ipa-inspection-callback-url`` kernel command
+    line argument to be incorrectly set, leading to Ironic Python Agent posting
+    introspection data back to Ironic rather than Ironic Inspector when using
+    the ``enable_inspector`` option.