Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support calling stg rebase without arguments #507

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

fbenkstein
Copy link
Contributor

When calling "git rebase" without a target commit argument then it will try to look up remote tracking branch and rebase onto that. This change makes "stg rebase" behave the same way. Note that this introduces a slight discrepancy with "stg rebase --interactive": in this case it will still use the stack base instead of the remote tracking branch.

@fbenkstein fbenkstein force-pushed the rebase-without-arguments branch from b7fc2e2 to 998b93d Compare December 24, 2024 08:18
@fbenkstein fbenkstein marked this pull request as draft December 24, 2024 08:30
@fbenkstein fbenkstein force-pushed the rebase-without-arguments branch from 998b93d to c090d24 Compare December 24, 2024 09:10
@fbenkstein fbenkstein marked this pull request as ready for review December 24, 2024 16:24
@fbenkstein
Copy link
Contributor Author

Sorry for the churn, I was still figuring out the testing.

@fbenkstein fbenkstein force-pushed the rebase-without-arguments branch 2 times, most recently from 8241322 to a245639 Compare December 24, 2024 16:49
When calling "git rebase" without a target commit argument then it will
try to look up remote tracking branch and rebase onto that. This change
makes "stg rebase" behave the same way. This slightly changes the
behavior of `stg rebase --interactive`: previously when called without
argument it would rebase onto the stack base, now it will rebase onto
the upstream branch.

Signed-off-by: Frank Benkstein <[email protected]>
@fbenkstein fbenkstein force-pushed the rebase-without-arguments branch from a245639 to 9e747c2 Compare December 24, 2024 16:50
@jpgrayson jpgrayson merged commit 112a2e2 into stacked-git:master Dec 24, 2024
10 checks passed
@jpgrayson
Copy link
Collaborator

Thanks for this PR. This seems like a sensible change.

@fbenkstein fbenkstein deleted the rebase-without-arguments branch December 24, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants