993 progress: convert test_version.py & test_item.py to pytest #1516
+386
−416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #993
unittest.TestCase.maxDiff = None
in pytest, Idecided to just take it out and leave it to the user to use
pytest -vv
ifthey want.
already going to be enormous so don't make it worse by adding semantic density.
TestCase.assertCountEqual()
isn't conveniently available inpytest. I didn't try to duplicate the exact semantics since simpler assertions
worked just as well, ie
assert set(some_object) == {"a", "b"}
organize tests. The tests inside them were converted to pytest though.
X-Cache
, that was a MISS inthe original but is a HIT here. I assume that's harmless?
PR Checklist:
scripts/test
)Documentation has been updated to reflect changes, if applicableor improvesoverall codebase code coverage.Changes are added to the CHANGELOG.