Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error on APILayoutStrategy when root_href is non-url #1498

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

jsignell
Copy link
Member

Related Issue(s):

Description:

Doesn't strictly disallow saving. Saving to a URL already throws an error if you are using the default stac_io so I think it is more appropriate to raise an error if you try to set the root to a non-url

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (67931b5) to head (e5cbe11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files          54       54           
  Lines        7509     7511    +2     
  Branches      906      907    +1     
=======================================
+ Hits         6868     6870    +2     
  Misses        457      457           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski self-requested a review January 21, 2025 11:50
pystac/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a CHANGELOG entry.

@gadomski gadomski added this pull request to the merge queue Jan 22, 2025
Merged via the queue into stac-utils:main with commit c033b51 Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow saving to the filesystem when using APILayoutStrategy
2 participants