Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classification:incomplete #33 #34

Closed
wants to merge 3 commits into from
Closed

Add classification:incomplete #33 #34

wants to merge 3 commits into from

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Jun 30, 2022

This PR is based on #32! It adds classification:incoplete and a recommendation to describe a range of values. See #33 for the discussion.

cc @pjhartzell @gadomski

@m-mohr m-mohr requested a review from drwelby June 30, 2022 19:55
@m-mohr m-mohr mentioned this pull request Jun 30, 2022
@m-mohr m-mohr linked an issue Jun 30, 2022 that may be closed by this pull request
@drwelby
Copy link
Collaborator

drwelby commented Jun 30, 2022

other synonyms to see how they look:

classification:incomplete
classification:partial
classification:limited

@m-mohr
Copy link
Contributor Author

m-mohr commented Jun 30, 2022

I found incomplete more intuitive and self-explanatory, but I'm a non-native speaker so may not get the nuances here.

@drwelby
Copy link
Collaborator

drwelby commented Jun 30, 2022

incomplete can also mean unfinished but I don't think it's a problem. I just wanted to think about other words now so I don't regret it when I think of the perfect word in two months.

@pjhartzell
Copy link
Contributor

The intent of classification:incomplete is to indicate that only a subset (e.g., multiple no-data) of the data are described in classification:classes?

I don't have a strong opinion on this. It's optional and doesn't break anything, so 👍 .

@m-mohr
Copy link
Contributor Author

m-mohr commented Jul 1, 2022

Yes, but it would not be really needed if we settle on ranges for classes. We need to decide for or against ranges at some point :-)

@m-mohr
Copy link
Contributor Author

m-mohr commented Jul 18, 2022

Hmm... I'm not entirely sure whether this is the way to go so waiting for further feedback. If no one else needs it, I'd also be fine to close this and use the raster band statistics to indicate incompleteness.

@m-mohr m-mohr closed this Sep 19, 2022
@m-mohr m-mohr deleted the incomplete branch September 19, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ranges?
3 participants