Make UAST check parallel #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warenlg
reviewed
Dec 12, 2018
vmarkovtsev
approved these changes
Dec 12, 2018
Signed-off-by: Hugo Mougard <[email protected]>
vmarkovtsev
requested changes
Dec 12, 2018
There was a problem hiding this comment.
Looking at the implementation and also taking into account that the speedup is not dramatic, I think that it's better to solve this properly after the release. We should allow BblfshClient to be constructed on top of a stub and a channel.
Thus we remove the type ambiguity in _check_vnode. It will also simplify code in other places: we are not supposed to work with low-level stubs directly. We should also add BblfshClient.close() which I suggested Waren a few days ago.
Our DataService.get_bblfsh() would return a BblfshClient inheritor which does the necessary bookkeeping in it's overloaded close().
This requires PR-ing to bblfsh/client-python and can take a few days.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394.