Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TEXT columns filterable and groupable #62

Closed
wants to merge 92 commits into from
Closed

Make TEXT columns filterable and groupable #62

wants to merge 92 commits into from

Conversation

carlosms
Copy link
Contributor

Fix #34.

fetch_metadata already makes string columns filterable and groupable, but TEXT was not included as a string type.
We might want to PR this to upstream also.

smacker and others added 30 commits April 23, 2019 20:13
@smacker
initial commit
909c12d 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
gitbase database included by default now
1bae367 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
improve superset config
5199ad2 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
make gitbase address configurable
6a2501e
@smacker
bblfsh container must be privileged
a0bb2c8 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
add build scripts for superset
4877817 
Signed-off-by: Maxim Sukharev <[email protected]>
@se7entyse7en
Initialize go.mod
5dbfcad 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@se7entyse7en
Add root command
13fb5e4 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@smacker
use new gitbase v0.20.0-beta4 instead of custom fork
f3d95ae 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
copy files to override
5ae9a6e 
Signed-off-by: Maxim Sukharev <[email protected]>
@se7entyse7en
Add compose package with Run function
1062106 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@se7entyse7en
Add install, start, stop, prune commands
9747eb8 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@se7entyse7en
Add main entrypoint
245233b 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@se7entyse7en
Add go.mod and go.sum
b904127 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@smacker
add bblfsh-web
fbe0d18 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
add simple patching
3e42bda 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
add bblfsh-web to docker-compose
a06b89b 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
pin superset on release--0.32
f7ff3e2 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
update sqlalchemy to be compatible with gitbase
f7c343d 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
update bblfsh css for release-0.32
3a374c5 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
update superset image
83a5595 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
update package.json and package-lock.json for release-0.32
6fbf92c 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
Merge pull request #2 from smacker/bblfsh-web
51b021c 
Bblfsh web
@smacker
gunicorn timeout should match SUPERSET_WEBSERVER_TIMEOUT
a6bcce0 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
add gitbase tables
cf38e0e 
Signed-off-by: Maxim Sukharev <[email protected]>
@se7entyse7en
Remove also volumes on prune
54eab1b 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@smacker
update superset config
eb73278 
Signed-off-by: Maxim Sukharev <[email protected]>
@smacker
Merge pull request #8 from smacker/update_config
7536186 
update superset config
@smacker
Merge pull request #5 from smacker/update_timeout
a5afdb8 
gunicorn timeout should match SUPERSET_WEBSERVER_TIMEOUT
@smacker
Merge pull request #6 from smacker/add_tables
73fd809 
add gitbase tables
carlosms and others added 22 commits May 14, 2019 11:41
@carlosms
Transform blob UAST columns to JSON strings
68fedb2 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms
Fix bblfsh import collision in PYTHONPATH
d29c33e 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms
Merge pull request #33 from carlosms/uast-viewer
fd269b5 
Add a UAST modal to SqlLab tab
@smacker
Merge pull request #37 from ricardobaeta/sourced-theme-v1
2039317 
Initial commit of source{d} Theme V1
@carlosms
Fix .less file path
d917190 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms
Rename go import paths to src-d
51ce9e9 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms
Add back the docker-compose instructions in README
58d4824 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms
Merge pull request #40 from carlosms/fix-less-build
94a3298 
Fix .less file path
@carlosms
Merge pull request #41 from carlosms/rename-imports
775e109 
Rename go import paths to src-d
@smacker
use bblfsh v2.13.0
868d691 
Signed-off-by: Maxim Sukharev <[email protected]>
@carlosms
Add basic travis conf for releases
ac87ab6 
Signed-off-by: Carlos Martín <[email protected]>
@smacker
Merge pull request #43 from smacker/bblfsh_2_13
a26b44f 
use bblfsh v2.13.0
@se7entyse7en
Merge pull request #4 from se7entyse7en/docker-compose-container
c377629 
Add fallback to docker-compose running inside container
@carlosms
Add long descriptions to each sub command
139612e 
Signed-off-by: Carlos Martín <[email protected]>
@smacker
Merge pull request #36 from carlosms/travis
848c408 
Add basic travis conf for releases
@smacker
fix incorrect docker hub name
09bb2eb 
Signed-off-by: Maxim Sukharev <[email protected]>
@carlosms @smacker
Add '--detach' to install subcommand call to 'up' (#45)
b04c0ea 
Signed-off-by: Carlos Martín <[email protected]>
@smacker
Use consistency: delegated for gitbase volume
6e591c4 
To avoid performance penalty on MacOS and Windows.
I also set `read_only: true` just in case

Signed-off-by: Maxim Sukharev <[email protected]>
@carlosms
Merge pull request #46 from carlosms/long-desc
b9d9dd1 
Add long descriptions to each sub command
@carlosms
Merge pull request #42 from carlosms/docs-compose
4c98efe 
Add back the docker-compose instructions in README
@smacker
Merge pull request #52 from smacker/gitbase_consistency_mode
7e2afbf 
Use consistency: delegated for gitbase volume
@carlosms
Make TEXT columns filterable and groupable
5c238aa 
Signed-off-by: Carlos Martín <[email protected]>
@carlosms carlosms requested review from smacker and dpordomingo May 21, 2019 14:05
@smacker
Copy link
Contributor

smacker commented May 21, 2019

Hm. TEXT type is meant to be huge text that doesn't make much sense to group of filter by user.
I mean maybe it's okay to fix as proposed right now. But better fix would be to return correct types from gitbase. Then for example repository name would be checked automatically but commit message not.

@smacker
Copy link
Contributor

smacker commented May 24, 2019

Here is the issue for gitbase: src-d/gitbase#824
It doesn't look like this issue is very critical. I would better wait for fix in gitbase than hacking superset.

@carlosms
Copy link
Contributor Author

Ok then, let's wait until we have the dashboards in place. If this filtering is needed for some of the charts we can rethink if we want to merge this PR.

@smacker smacker closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@se7entyse7en se7entyse7en se7entyse7en approved these changes

@smacker smacker Awaiting requested review from smacker

@dpordomingo dpordomingo Awaiting requested review from dpordomingo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables' columns are nor groupable nor filterable by default
5 participants
@carlosms @smacker @se7entyse7en @villebro @ricardobaeta