Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables' columns are nor groupable nor filterable by default #34

Open
se7entyse7en opened this issue May 9, 2019 · 3 comments
Open

Tables' columns are nor groupable nor filterable by default #34

se7entyse7en opened this issue May 9, 2019 · 3 comments
Labels
blocked This is blocked for some reason bug Something isn't working

Comments

@se7entyse7en
Copy link
Contributor

se7entyse7en commented May 9, 2019

A column can be groupable, filterable and is_temporal.

The columns of the imported gitbase tables are nor groupable nor filterable by default. So before creating a chart that needs grouping or filtering on some columns, the user needs to get to the table configuration and mark the columns as manually.

Example of some columns of the gitbase.commits table manually marked both as groupable and filterable.

Screenshot 2019-05-09 at 11 45 59

Marking them during the creation of the tables would improve the user experience.

On the other hand, each column with type TIMESTAMP is already automatically marked as is_temporal.

@smacker
Copy link
Contributor

smacker commented May 17, 2019

Those 2 fields affect only dashboards according to documentation:
https://superset.incubator.apache.org/tutorial.html#adding-a-new-table

For example, if the field is "filterable" you can use Filter Box on dasboard and filter data for the chart provided by a user https://superset.incubator.apache.org/faq.html#how-to-add-dynamic-filters-to-a-dashboard

It doesn't affect the creation of the charts. Though we may want to set these fields for some columns. For example, it makes sense to do for commiter_email in commits table. So user charts can be filtered on dashbord.

@smacker
Copy link
Contributor

smacker commented Jul 24, 2019

it was at least partially fixed by new gitbase

@carlosms carlosms added the blocked This is blocked for some reason label Aug 13, 2019
@se7entyse7en
Copy link
Contributor Author

se7entyse7en commented Oct 17, 2019

Let's have a look again at this once #306 is closed. Also given that this doesn't affect main functionalities. Moving this back to the backlog for now.

@se7entyse7en se7entyse7en added the bug Something isn't working label Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This is blocked for some reason bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants