Merge pull request #951 from ajnavarro/update-go-mysql-server-210819

Upgrade go-mysql-server version

docs/using-gitbase/configuration.md

@@ -26,8 +26,7 @@
 |:-----|:-----|:------------|
 |`INMEMORY_JOINS`|environment|If set it will perform all joins in memory. Default is off.|
 |`inmemory_joins`|session|If set it will perform all joins in memory. Default is off. This has precedence over `INMEMORY_JOINS`.|
-|`MAX_MEMORY_JOIN`|environment|The maximum number of memory, in megabytes, that can be consumed by go-mysql-server before switching to multipass mode in joins. Default is the 20% of all available physical memory.|
-|`max_memory_joins`|session|The maximum number of memory, in megabytes, that can be consumed by go-mysql-server before switching to multipass mode in joins. Default is the 20% of all available physical memory. This has precedence over `MAX_MEMORY_JOIN`.|
+|`MAX_MEMORY`|environment|The maximum number of memory, in megabytes, that can be consumed by go-mysql-server. Any in-memory caches or computations will no longer try to use memory when the limit is reached. Note that this may cause certain queries to fail if there is not enough memory available, such as queries using DISTINCT, ORDER BY or GROUP BY with groupings.|
 |`DEBUG_ANALYZER`|environment|If set, the analyzer will print debug messages. Default is off.|
 |`PILOSA_INDEX_THREADS`|environment|Number of threads used in index creation. Default is the number of cores available in the machine.|
 |`pilosa_index_threads`|environment|Number of threads used in index creation. Default is the number of cores available in the machine. This has precedence over `PILOSA_INDEX_THREADS`.|

docs/using-gitbase/functions.md

@@ -26,70 +26,71 @@ These are all functions that are available because they are implemented in `go-m
 <!-- BEGIN FUNCTIONS -->
 |     Name     |                                               Description                                                                      |
 |:-------------|:-------------------------------------------------------------------------------------------------------------------------------|
-|`ARRAY_LENGTH(json)`|If the json representation is an array, this function returns its size.|
-|`AVG(expr)`|Returns the average value of expr in all rows.|
-|`CEIL(number)`|Return the smallest integer value that is greater than or equal to `number`.|
-|`CEILING(number)`|Return the smallest integer value that is greater than or equal to `number`.|
-|`CHAR_LENGTH(str)`|Return the length of the string in characters.|
-|`COALESCE(...)`|The function returns the first non-null value in a list.|
-|`CONCAT(...)`|Concatenate any group of fields into a single string.|
-|`CONCAT_WS(sep, ...)`|Concatenate any group of fields into a single string. The first argument is the separator for the rest of the arguments. The separator is added between the strings to be concatenated. The separator can be a string, as can the rest of the arguments. If the separator is NULL, the result is NULL.|
-|`CONNECTION_ID()`|Return the current connection ID.|
-|`COUNT(expr)`| Returns a count of the number of non-NULL values of expr in the rows retrieved by a SELECT statement.|
-|`DATE_ADD(date, interval)`|Adds the interval to the given date.|
-|`DATE_SUB(date, interval)`|Subtracts the interval from the given date.|
-|`DAY(date)`|Synonym for DAYOFMONTH().|
-|`DATE(date)`|Returns the date part of the given date.|
-|`DAYOFMONTH(date)`|Return the day of the month (0-31).|
-|`DAYOFWEEK(date)`|Returns the day of the week of the given date.|
-|`DAYOFYEAR(date)`|Returns the day of the year of the given date.|
-|`FIRST(expr)`|Returns the first value in a sequence of elements of an aggregation.|
-|`FLOOR(number)`|Returns the largest integer value that is less than or equal to `number`.|
-|`FROM_BASE64(str)`|Decodes the base64-encoded string str.|
-|`GREATEST(...)`|Returns the greatest numeric or string value.|
-|`HOUR(date)`|Returns the hours of the given date.|
-|`IFNULL(expr1, expr2)`|If expr1 is not NULL, IFNULL() returns expr1; otherwise it returns expr2.|
-|`IS_BINARY(blob)`|Returns whether a BLOB is a binary file or not.|
-|`JSON_EXTRACT(json_doc, path, ...)`|Extracts data from a json document using json paths. Extracting a string will result in that string being quoted. To avoid this, use `JSON_UNQUOTE(JSON_EXTRACT(json_doc, path, ...))`.|
-|`JSON_UNQUOTE(json)`|Unquotes JSON value and returns the result as a utf8mb4 string.|
-|`LAST(expr)`|Returns the last value in a sequence of elements of an aggregation.|
-|`LEAST(...)`|Returns the smaller numeric or string value.|
-|`LENGTH(str)`|Return the length of the string in bytes.|
-|`LN(X)`|Return the natural logarithm of X.|
-|`LOG(X), LOG(B, X)`|If called with one parameter, this function returns the natural logarithm of X. If called with two parameters, this function returns the logarithm of X to the base B. If X is less than or equal to 0, or if B is less than or equal to 1, then NULL is returned.|
-|`LOG10(X)`|Returns the base-10 logarithm of X.|
-|`LOG2(X)`|Returns the base-2 logarithm of X.|
-|`LOWER(str)`|Returns the string str with all characters in lower case.|
-|`LPAD(str, len, padstr)`|Return the string argument, left-padded with the specified string.|
-|`LTRIM(str)`|Returns the string str with leading space characters removed.|
-|`MAX(expr)`|Returns the maximum value of expr in all rows.|
-|`MID(str, pos, [len])`|Return a substring from the provided string starting at `pos` with a length of `len` characters. If no `len` is provided, all characters from `pos` until the end will be taken.|
-|`MIN(expr)`|Returns the minimum value of expr in all rows.|
-|`MINUTE(date)`|Returns the minutes of the given date.|
-|`MONTH(date)`|Returns the month of the given date.|
-|`NOW()`|Returns the current timestamp.|
-|`NULLIF(expr1, expr2)`|Returns NULL if expr1 = expr2 is true, otherwise returns expr1.|
-|`POW(X, Y)`|Returns the value of X raised to the power of Y.|
-|`REPEAT(str, count)`|Returns a string consisting of the string str repeated count times.|
-|`REPLACE(str,from_str,to_str)`|Returns the string str with all occurrences of the string from_str replaced by the string to_str.|
-|`REVERSE(str)`|Returns the string str with the order of the characters reversed.|
-|`ROUND(number, decimals)`|Round the `number` to `decimals` decimal places.|
-|`RPAD(str, len, padstr)`|Returns the string str, right-padded with the string padstr to a length of len characters.|
-|`RTRIM(str)`|Returns the string str with trailing space characters removed.|
-|`SECOND(date)`|Returns the seconds of the given date.|
-|`SLEEP(seconds)`|Wait for the specified number of seconds (can be fractional).|
-|`SOUNDEX(str)`|Returns the soundex of a string.|
-|`SPLIT(str,sep)`|Receives a string and a separator and returns the parts of the string split by the separator as a JSON array of strings.|
-|`SQRT(X)`|Returns the square root of a nonnegative number X.|
-|`SUBSTR(str, pos, [len])`|Return a substring from the provided string starting at `pos` with a length of `len` characters. If no `len` is provided, all characters from `pos` until the end will be taken.|
-|`SUBSTRING(str, pos, [len])`|Return a substring from the provided string starting at `pos` with a length of `len` characters. If no `len` is provided, all characters from `pos` until the end will be taken.|
-|`SUM(expr)`|Returns the sum of expr in all rows.|
-|`TO_BASE64(str)`|Encodes the string str in base64 format.|
-|`TRIM(str)`|Returns the string str with all spaces removed.|
-|`UPPER(str)`|Returns the string str with all characters in upper case.|
-|`WEEKDAY(date)`|Returns the weekday of the given date.|
-|`YEAR(date)`|Returns the year of the given date.|
-|`YEARWEEK(date, mode)`|Returns year and week for a date. The year in the result may be different from the year in the date argument for the first and the last week of the year.|
+|`ARRAY_LENGTH(json)`|if the json representation is an array, this function returns its size.|
+|`AVG(expr)`| returns the average value of expr in all rows.|
+|`CEIL(number)`| returns the smallest integer value that is greater than or equal to `number`.|
+|`CEILING(number)`| returns the smallest integer value that is greater than or equal to `number`.|
+|`CHAR_LENGTH(str)`| returns the length of the string in characters.|
+|`COALESCE(...)`| returns the first non-null value in a list.|
+|`CONCAT(...)`| concatenates any group of fields into a single string.|
+|`CONCAT_WS(sep, ...)`| concatenates any group of fields into a single string. The first argument is the separator for the rest of the arguments. The separator is added between the strings to be concatenated. The separator can be a string, as can the rest of the arguments. If the separator is NULL, the result is NULL.|
+|`CONNECTION_ID()`| returns the current connection ID.|
+|`COUNT(expr)`|  returns a count of the number of non-NULL values of expr in the rows retrieved by a SELECT statement.|
+|`DATE_ADD(date, interval)`| adds the interval to the given `date`.|
+|`DATE_SUB(date, interval)`| subtracts the interval from the given `date`.|
+|`DAY(date)`| is a synonym for DAYOFMONTH().|
+|`DATE(date)`| returns the date part of the given `date`.|
+|`DAYOFMONTH(date)`| returns the day of the month (0-31).|
+|`DAYOFWEEK(date)`| returns the day of the week of the given `date`.|
+|`DAYOFYEAR(date)`| returns the day of the year of the given `date`.|
+|`FIRST(expr)`| returns the first value in a sequence of elements of an aggregation.|
+|`FLOOR(number)`| returns the largest integer value that is less than or equal to `number`.|
+|`FROM_BASE64(str)`| decodes the base64-encoded string `str`.|
+|`GREATEST(...)`| returns the greatest numeric or string value.|
+|`HOUR(date)`| returns the hours of the given `date`.|
+|`IFNULL(expr1, expr2)`| if `expr1` is not NULL, it returns `expr1`; otherwise it returns `expr2`.|
+|`IS_BINARY(blob)`| returns whether a `blob` is a binary file or not.|
+|`JSON_EXTRACT(json_doc, path, ...)`| extracts data from a json document using json paths. Extracting a string will result in that string being quoted. To avoid this, use `JSON_UNQUOTE(JSON_EXTRACT(json_doc, path, ...))`.|
+|`JSON_UNQUOTE(json)`| unquotes JSON value and returns the result as a utf8mb4 string.|
+|`LAST(expr)`| returns the last value in a sequence of elements of an aggregation.|
+|`LEAST(...)`| returns the smaller numeric or string value.|
+|`LENGTH(str)`| returns the length of the string in bytes.|
+|`LN(X)`| returns the natural logarithm of `X`.|
+|`LOG(X), LOG(B, X)`| if called with one parameter, this function returns the natural logarithm of `X`. If called with two parameters, this function returns the logarithm of `X` to the base `B`. If `X` is less than or equal to 0, or if `B` is less than or equal to 1, then NULL is returned.|
+|`LOG10(X)`| returns the base-10 logarithm of `X`.|
+|`LOG2(X)`| returns the base-2 logarithm of `X`.|
+|`LOWER(str)`| returns the string `str` with all characters in lower case.|
+|`LPAD(str, len, padstr)`| returns the string `str`, left-padded with the string `padstr` to a length of `len` characters.|
+|`LTRIM(str)`| returns the string `str` with leading space characters removed.|
+|`MAX(expr)`| returns the maximum value of `expr` in all rows.|
+|`MID(str, pos, [len])`| returns a substring from the provided string starting at `pos` with a length of `len` characters. If no `len` is provided, all characters from `pos` until the end will be taken.|
+|`MIN(expr)`| returns the minimum value of `expr` in all rows.|
+|`MINUTE(date)`| returns the minutes of the given `date`.|
+|`MONTH(date)`| returns the month of the given `date`.|
+|`NOW()`| returns the current timestamp.|
+|`NULLIF(expr1, expr2)`| returns NULL if `expr1 = expr2` is true, otherwise returns `expr1`.|
+|`POW(X, Y)`| returns the value of `X` raised to the power of `Y`.|
+|`REGEXP_MATCHES(text, pattern, [flags])`| returns an array with the matches of the `pattern` in the given `text`. Flags can be given to control certain behaviours of the regular expression. Currently, only the `i` flag is supported, to make the comparison case insensitive.|
+|`REPEAT(str, count)`| returns a string consisting of the string `str` repeated `count` times.|
+|`REPLACE(str,from_str,to_str)`| returns the string `str` with all occurrences of the string `from_str` replaced by the string `to_str`.|
+|`REVERSE(str)`| returns the string `str` with the order of the characters reversed.|
+|`ROUND(number, decimals)`| rounds the `number` to `decimals` decimal places.|
+|`RPAD(str, len, padstr)`| returns the string `str`, right-padded with the string `padstr` to a length of `len` characters.|
+|`RTRIM(str)`| returns the string `str` with trailing space characters removed.|
+|`SECOND(date)`| returns the seconds of the given `date`.|
+|`SLEEP(seconds)`| waits for the specified number of seconds (can be fractional).|
+|`SOUNDEX(str)`| returns the soundex of a string.|
+|`SPLIT(str,sep)`| returns the parts of the string `str` split by the separator `sep` as a JSON array of strings.|
+|`SQRT(X)`| returns the square root of a nonnegative number `X`.|
+|`SUBSTR(str, pos, [len])`| returns a substring from the string `str` starting at `pos` with a length of `len` characters. If no `len` is provided, all characters from `pos` until the end will be taken.|
+|`SUBSTRING(str, pos, [len])`| returns a substring from the string `str` starting at `pos` with a length of `len` characters. If no `len` is provided, all characters from `pos` until the end will be taken.|
+|`SUM(expr)`| returns the sum of `expr` in all rows.|
+|`TO_BASE64(str)`| encodes the string `str` in base64 format.|
+|`TRIM(str)`| returns the string `str` with all spaces removed.|
+|`UPPER(str)`| returns the string `str` with all characters in upper case.|
+|`WEEKDAY(date)`| returns the weekday of the given `date`.|
+|`YEAR(date)`| returns the year of the given `date`.|
+|`YEARWEEK(date, mode)`| returns year and week for a date. The year in the result may be different from the year in the date argument for the first and the last week of the year.|
 <!-- END FUNCTIONS -->
 
 ## Note about uast, uast_mode, uast_xpath and uast_children functions

docs/using-gitbase/supported-clients.md

@@ -1,6 +1,6 @@
 # Supported clients
 
-These are the clients we actively test against to check are compatible with go-mysql-server. Other clients may also work, but we don't check on every build if we remain compatible with them.
+These are the clients we actively test against to check that they are compatible with go-mysql-server. Other clients may also work, but we don't check on every build if we remain compatible with them.
 
 - Python
   - [pymysql](#pymysql)
@@ -16,7 +16,7 @@ These are the clients we actively test against to check are compatible with go-m
 - Java/JVM
   - [mariadb-java-client](#mariadb-java-client)
 - Go
-  - [go-mysql-driver/mysql](#go-mysql-driver-mysql)
+  - [go-mysql-driver/mysql](#go-sql-drivermysql)
 - C
   - [mysql-connector-c](#mysql-connector-c)
 - Grafana
@@ -218,7 +218,7 @@ func main() {
 }
 ```
 
-### #mysql-connector-c
+### mysql-connector-c
 
 ```c
 #include <my_global.h>
@@ -271,4 +271,4 @@ int main(int argc, char **argv)
 
     return 0;
 }
-```
+```

go.mod

@@ -8,7 +8,8 @@ require (
 	github.com/gliderlabs/ssh v0.2.0 // indirect
 	github.com/go-kit/kit v0.8.0
 	github.com/go-sql-driver/mysql v1.4.1
-	github.com/hashicorp/golang-lru v0.5.1
+	github.com/gorilla/handlers v1.4.0 // indirect
+	github.com/hashicorp/golang-lru v0.5.3
 	github.com/hhatto/gocloc v0.3.0
 	github.com/jessevdk/go-flags v1.4.0
 	github.com/miekg/dns v1.1.1 // indirect
@@ -19,7 +20,7 @@ require (
 	github.com/src-d/go-borges v0.0.0-20190628121335-da12a84d60fd
 	github.com/src-d/go-git v4.7.0+incompatible
 	github.com/src-d/go-git-fixtures v3.5.1-0.20190605154830-57f3972b0248+incompatible
-	github.com/src-d/go-mysql-server v0.4.1-0.20190730105128-550cc54baee2
+	github.com/src-d/go-mysql-server v0.4.1-0.20190821121850-0e0249cf7bc0
 	github.com/stretchr/testify v1.3.0
 	github.com/uber-go/atomic v1.4.0 // indirect
 	github.com/uber/jaeger-client-go v2.16.0+incompatible