gitbase: fix linter errors

Signed-off-by: Javi Fontan <[email protected]>
src-d · Jun 20, 2019 · 044094c · 044094c
1 parent 2c1a0d6
commit 044094c
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 8 deletions.
diff --git a/common_test.go b/common_test.go
@@ -321,8 +321,15 @@ func newMultiLibrary() (*multiLibrary, error) {
 	}
 
 	libs := libraries.New(libraries.Options{})
-	libs.Add(plainLib)
-	libs.Add(sivaLib)
+
+	err = libs.Add(plainLib)
+	if err != nil {
+		return nil, err
+	}
+	err = libs.Add(sivaLib)
+	if err != nil {
+		return nil, err
+	}
 
 	return &multiLibrary{
 		lib:     libs,
@@ -465,8 +472,8 @@ func copyFile(
 
 	_, err = io.Copy(fd, fo)
 	if err != nil {
-		fd.Close()
-		dstFS.Remove(dst)
+		_ = fd.Close()
+		_ = dstFS.Remove(dst)
 		return err
 	}
 

diff --git a/repositories_test.go b/repositories_test.go
@@ -26,7 +26,8 @@ func TestRepositoriesTable(t *testing.T) {
 
 	path := fixtures.Basic().ByTag("worktree").One().Worktree().Root()
 	for _, id := range repoIDs {
-		lib.AddPlain(id, path, nil)
+		err = lib.AddPlain(id, path, nil)
+		require.NoError(err)
 	}
 
 	session := NewSession(pool)

diff --git a/repository_pool_test.go b/repository_pool_test.go
@@ -108,8 +108,10 @@ func TestRepositoryPoolIterator(t *testing.T) {
 	require.NoError(err)
 
 	pool := NewRepositoryPool(cache.DefaultMaxSize, lib)
-	lib.AddPlain("0", path, nil)
-	lib.AddPlain("1", path, nil)
+	err = lib.AddPlain("0", path, nil)
+	require.NoError(err)
+	err = lib.AddPlain("1", path, nil)
+	require.NoError(err)
 
 	iter, err := pool.RepoIter()
 	require.NoError(err)

diff --git a/squash_iterator_test.go b/squash_iterator_test.go
@@ -785,7 +785,8 @@ func setupIterWithErrors(t *testing.T, badRepo bool, skipErrors bool) (*sql.Cont
 		ok, err := IsGitRepo(path)
 		require.NoError(err)
 		if ok {
-			lib.AddPlain(pathToName(path), path, nil)
+			err = lib.AddPlain(pathToName(path), path, nil)
+			require.NoError(err)
 		}
 	}