Add short flags and fix conflicting host flag #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -h flag conflicts with help. Now you don't need to type out the entire long-form of the flag to specify a host. Signed-off-by: Rafael Espinoza <[email protected]>
Signed-off-by: Rafael Espinoza <[email protected]>
Signed-off-by: Rafael Espinoza <[email protected]>
Didn't do Put.TTR flag since it'd conflict with Tube. Signed-off-by: Rafael Espinoza <[email protected]>
Signed-off-by: Rafael Espinoza <[email protected]>
rafaelespinoza
force-pushed
the
re/update_cli_flags
branch
from
fe928a4 to
b26d609
Compare
rafaelespinoza
changed the title
Signed-off-by: Rafael Espinoza <[email protected]>
rafaelespinoza
force-pushed
the
re/update_cli_flags
branch
from
e4e0a9d to
abe3fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nice tool. But there are some minor usability annoyances with the input flags.
Addresses the
host=flag short-form that conflicts with--help's short form. Both are-handhelptakes precedence. Get around this by specifying an alternative short-form forhost. This is similar to #22.Fix a typo in usage text.
Adds some other missing short-form flags.
I was careful to look for creating conflicts and couldn't find any new ones. Going through each subcommand's usage func shows that it still works. From what I understand, if there was a conflicting flag, then
beanstool <subcommand> -hwould output something like:Which doesn't seem to happen.
Let me know what you think, thanks.