Skip to content

Commit

Permalink
Fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
dpprdan committed Apr 2, 2021
1 parent 03a5b84 commit ce917ba
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 16 deletions.
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ Internal changes only.

# RPostgres 1.0-4 (2017-12-20)

- Only call `PQcancel()` if the query hasn't completed, fixes transactions on Amazon RedShift (#159, @mmuurr).
- Fix installation on MacOS.
- Only call `PQcancel()` if the query hasn't completed, fixes transactions on Amazon Redshift (#159, @mmuurr).
- Fix installation on macOS.
- Check libpq version in configure script (need at least 9.0).
- Fix UBSAN warning: reference binding to null pointer (#156).
- Fix rchk warning: PROTECT internal temporary SEXP objects (#157).
Expand Down
6 changes: 3 additions & 3 deletions R/PqResult.R
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ setMethod("dbColumnInfo", "PqResult", function(res, ...) {
#' fetches and clears for you.
#'
#' @param conn A [PqConnection-class] created by [dbConnect()].
#' @param statement An SQL string to execute
#' @param statement An SQL string to execute.
#' @param params A list of query parameters to be substituted into
#' a parameterised query. Query parameters are sent as strings, and the
#' correct type is imputed by PostgreSQL. If this fails, you can manually
#' cast the parameter with e.g. `"$1::bigint"`.
#' @param ... Another arguments needed for compatibility with generic (
#' currently ignored).
#' @param ... Other arguments needed for compatibility with generic (currently
#' ignored).
#' @examples
#' # For running the examples on systems without PostgreSQL connection:
#' run <- postgresHasDefault()
Expand Down
5 changes: 3 additions & 2 deletions R/quote.R
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ NULL
#' at most one `table` component and at most one `schema` component.
#'
#' @param conn A [PqConnection-class] created by `dbConnect()`
#' @param x A character to escaped
#' @param ... Other arguments needed for compatibility with generic
#' @param x A character vector to be quoted.
#' @param ... Other arguments needed for compatibility with generic (currently
#' ignored).
#' @examples
#' # For running the examples on systems without PostgreSQL connection:
#' run <- postgresHasDefault()
Expand Down
2 changes: 1 addition & 1 deletion R/tables.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#' with [DBI::dbDataType()]).
#' @param copy If `TRUE`, serializes the data frame to a single string
#' and uses `COPY name FROM stdin`. This is fast, but not supported by
#' all postgres servers (e.g. Amazon's redshift). If `FALSE`, generates
#' all postgres servers (e.g. Amazon's Redshift). If `FALSE`, generates
#' a single SQL string. This is slower, but always supported.
#'
#' @examples
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RPostgres is an DBI-compliant interface to the postgres database. It's a ground-
don't need to worry about leaking connections or memory.

* Is a little faster, saving ~5 ms per query. (For reference, it takes around 5ms
to retrive a 1000 x 25 result set from a local database, so this is
to retrieve a 1000 x 25 result set from a local database, so this is
decent speed up for smaller queries.)

* A simplified build process that relies on system libpq.
Expand Down
6 changes: 3 additions & 3 deletions man/postgres-query.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/postgres-tables.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions man/quote.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vignettes/work-queue.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ con <- dbConnect(RPostgres::Postgres())
dbExecute(con, "LISTEN grapevine")
```

...in this case, "grapevine" is arbitary, we don't need to create channels ahead of time.
...in this case, "grapevine" is arbitrary, we don't need to create channels ahead of time.
To make sure we have something to receive, we can start a separate R process using [callr](https://CRAN.R-project.org/package=callr).
Ordinarily this would be part of another R script, maybe on another computer.
This will wait a bit, and use ``NOTIFY`` to send a message, then finish:
Expand Down

0 comments on commit ce917ba

Please sign in to comment.