Fixed an issue where a crash would occur when applying an external update to list content while a live reorder event was occurring #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date to list content while a live reorder event was occurring.
kyleve
commented
Nov 28, 2023
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
|
|
||
| Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { [weak self] _ in |
There was a problem hiding this comment.
- Remove this or add a start/stop button to the nav bar
kyleve
commented
Nov 28, 2023
| @@ -11,7 +11,7 @@ import Foundation | |||
| /// A queue used to synchronized and serialize changes made to the backing collection view, | |||
| /// to work around either bugs or confusing behavior. | |||
| /// | |||
| /// ## Handling Re-ordering (`isQueuingForReorderEvent`) | |||
| /// ## Handling Re-ordering (`isQueuingToApplyReorderEvent`) | |||
There was a problem hiding this comment.
- Update this comment
kyleve
commented
Nov 28, 2023
| /// Set by consumers to enable and disable queueing during a reorder event. | ||
| var isQueuingForReorderEvent : Bool = false { | ||
| /// Set by consumers to enable and disable queueing when a reorder event is being applied. | ||
| var isQueuingToApplyReorderEvent : Bool = false { | ||
| didSet { | ||
| self.runIfNeeded() |
There was a problem hiding this comment.
- Double check we don't need this when a re-order event is abandoned by the user
rogerogden
approved these changes
Nov 28, 2023
robmaceachern
approved these changes
Nov 29, 2023
|
Testing POS integration here: https://github.com/squareup/ios-register/pull/95745 And then will merge for this week's release if it's good. |
|
Ugh, either this or the first responder fix seems to have caused some sort of bug: |
|
(Side note, I hate those damn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another edge case in the reordering APIs in collection view wherein if the following occurs:
To work around this, we extend
ListChangesQueue, to also queue changes if a live reorder event is occurring.The
hasUncommittedUpdatesAPI docs have some hints to this, albeit seemingly not quite correct:https://block.atlassian.net/browse/AP-26351
Checklist
Please do the following before merging:
Mainsection.