PR: Fix setting custom run configurations for multiple executors (Run) #23580
Conversation
- This will allow users to execute a single file with different, custom configurations per executor. - We use a new option name for that (last_used_parameters_per_executor), so that when moving from Spyder 6.0.3 or less to 6.0.4, and viceversa, users don't encounter errors. - Fix tests related to the change in option name.
This allows each executor run with its own set of custom parameters, instead of only the one currently selected in RunDialog.
- This fixes a serious UX bug: after configuring an executor in RunDialog, it was used by the run buttons (i.e. Run file, Run cell, etc) for execution. - That's not only very counterintuitive (because the RunDialog's UI clearly signals that it's used only for configuration) but also breaks the Spyder 5 behavior.
ccordoba12
force-pushed
the
issue-22496
branch
from
9e3fea6 to
2b3ff41
Compare
Also, skip test that started to fail in Python 3.8
ccordoba12
force-pushed
the
issue-22496
branch
from
2b3ff41 to
c559618
Compare
|
Gave this a check and seems like things are working as described 👍 However, one thing that I'm not sure now how to achieve as thing are in this PR is running a file using an external console. Since now the run config dialog is not coupled with the run button seems to me that there is no way to run a file using an external console. Or maybe the action to run on an external terminal exists somewhere? Also, as a side note, something that I started thinking while checking this is that for people to be able to easy config the specific executor they want to use without having to search for it over the dropdown of the run config file, could it make sense to add actions that open the run config with the specific executor already selected? So, using the Debugger executor as an example, we could add a What do you think @ccordoba12 ? |
Great! Glad things are working as expected for you too.
Good point @dalthviz. There's no action to run a file in an external terminal, so I'll add one to the Run menu as part of this PR.
Very good suggestion @dalthviz! Please open a new issue about it so we don't forget to address it for 6.1.0 (since that requires adding several new actions to the UI, I don't think it's a good idea to implement it in 6.0.5). |
This is necessary now that the Run buttons use a default executor.
|
@meeseeksdev please backport to 6.x |
…ns for multiple executors (Run)
…580-on-6.x Backport PR #23580 on branch 6.x (PR: Fix setting custom run configurations for multiple executors (Run))
Description of Changes
Configuration per filedialog. Now, we save the last run config per executor and use it for the one users choose in the main toolbar or menus. This way, each executor will use its own config regardless of what's selected in that dialog.Configuration per file. That was a serious UX bug because if users had selected the Debugger inConfiguration per file, then the Run actions were tied to that plugin instead of simply running the file (as in Spyder 5).Visual changes
New action to run a file in an external, system terminal
Issue(s) Resolved
Fixes #22496
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12