Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix --connect-to-kernel cli option when a project is loaded at startup #23498

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

Social-Mean
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #23497

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @Social-Mean

@pep8speaks
Copy link

pep8speaks commented Jan 17, 2025

Hello @Social-Mean! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-23 05:21:43 UTC

@Social-Mean Social-Mean changed the title Fix issue #23497 PR: Fix issue #23497 Jan 17, 2025
@Social-Mean Social-Mean marked this pull request as ready for review January 17, 2025 11:58
@Social-Mean
Copy link
Contributor Author

This PR is a supplement to #23444

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Social-Mean, quick feedback for your about your proposed solution.

spyder/plugins/projects/plugin.py Outdated Show resolved Hide resolved
@Social-Mean
Copy link
Contributor Author

Social-Mean commented Jan 23, 2025

@ccordoba12 I have tested on my computer; everything works fine as expected now :)

@ccordoba12
Copy link
Member

Thanks @Social-Mean! However, this still needs a little bit more work, so I'll give you a hand to finish it.

@ccordoba12 ccordoba12 changed the title PR: Fix issue #23497 PR: Fix --connect-to-kernel cli option when --project is also used Jan 29, 2025
@ccordoba12 ccordoba12 changed the title PR: Fix --connect-to-kernel cli option when --project is also used PR: Fix --connect-to-kernel cli option when --project is also used or a project is loaded at startup Jan 29, 2025
@ccordoba12 ccordoba12 changed the title PR: Fix --connect-to-kernel cli option when --project is also used or a project is loaded at startup PR: Fix --connect-to-kernel cli option when a project is loaded at startup Jan 29, 2025
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Social-Mean for your work on this!

@ccordoba12 ccordoba12 merged commit 66d9f6a into spyder-ide:master Jan 30, 2025
17 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

@Social-Mean
Copy link
Contributor Author

Social-Mean commented Jan 30, 2025 via email

@ccordoba12
Copy link
Member

Great! Glad you liked working with us and improving Spyder.

ccordoba12 pushed a commit that referenced this pull request Jan 30, 2025
…ption when a project is loaded at startup) (#23589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open project command line option conflicts with the new connect to kernel one
3 participants