Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add ipython_pygments_lexers as a new dependency #23481

Merged
merged 4 commits into from
Jan 18, 2025

Conversation

takluyver
Copy link
Contributor

Description of Changes

The IPython Pygments lexers are moving to a separate package (ipython/ipython#14520). Importing the IPython classes from IPython.lib.lexers will still work for a while, but importing the incidental things which that module imported from pygments won't, so I've switched those imports to point to pygments.

Issue(s) Resolved

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @takluyver

@takluyver
Copy link
Contributor Author

I see the tests still run on some older versions of Python. I started ipython_pygments_lexer testing with Python >=3.11, the same as the development version of IPython, but I'm pretty sure it's not using any fancy features, so it's probably easy to support older Python versions. What's the minimum that we want?

@takluyver
Copy link
Contributor Author

I've extended compatibility back to Python 3.8, as that didn't need any code changes.

@ccordoba12
Copy link
Member

Thanks @takluyver for your help with this! You also need to add the new dependency to

  • binder/environment.yml
  • requirements/main.yml
  • spyder/dependencies.py

We have a test that checks that dependencies in those files, plus setup.py, are in sync. In addition, the package needs to be available in Conda-forge too for this work.

@ccordoba12 ccordoba12 added this to the v6.0.5 milestone Jan 16, 2025
@ccordoba12 ccordoba12 changed the title IPython lexers are being split out as a separate package PR: Add ipython_pygments_lexers as a new dependency Jan 16, 2025
@ccordoba12 ccordoba12 modified the milestones: v6.0.5, v6.0.4, v6.1.0 Jan 17, 2025
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @takluyver!

@ccordoba12 ccordoba12 merged commit ec4def2 into spyder-ide:master Jan 18, 2025
27 checks passed
@takluyver takluyver deleted the patch-1 branch January 20, 2025 09:00
@takluyver
Copy link
Contributor Author

Thanks Carlos! Am I right in thinking that you maintain qtconsole as well? I don't think the PR there is at all urgent, if it's easier to wait until qtconsole drops Python 3.8 anyway.

@ccordoba12
Copy link
Member

Am I right in thinking that you maintain qtconsole as well?

Yep, that's right.

I don't think the PR there is at all urgent, if it's easier to wait until qtconsole drops Python 3.8 anyway.

I forgot about it, but I'll merge your PR there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants