-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add ipython_pygments_lexers
as a new dependency
#23481
Conversation
I see the tests still run on some older versions of Python. I started |
I've extended compatibility back to Python 3.8, as that didn't need any code changes. |
Thanks @takluyver for your help with this! You also need to add the new dependency to
We have a test that checks that dependencies in those files, plus |
ipython_pygments_lexers
as a new dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @takluyver!
Thanks Carlos! Am I right in thinking that you maintain qtconsole as well? I don't think the PR there is at all urgent, if it's easier to wait until qtconsole drops Python 3.8 anyway. |
Yep, that's right.
I forgot about it, but I'll merge your PR there too. |
Description of Changes
The IPython Pygments lexers are moving to a separate package (ipython/ipython#14520). Importing the IPython classes from
IPython.lib.lexers
will still work for a while, but importing the incidental things which that module imported from pygments won't, so I've switched those imports to point to pygments.Issue(s) Resolved
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @takluyver