Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Enable comms to work across different Python versions #492

Merged
merged 21 commits into from
May 29, 2024
Prev Previous commit
Next Next commit
save return value
Quentin Peter committed May 27, 2024
commit 674f60de8b89feed55da70044987804f2caa9ef2
3 changes: 2 additions & 1 deletion spyder_kernels/comms/commbase.py
Original file line number Diff line number Diff line change
@@ -457,12 +457,13 @@ def _handle_remote_call_reply(self, msg_dict, buffers):
call_name = content['call_name']
is_error = content['is_error']
return_value = content['call_return_value']
# Prepare return value
if is_error:
return_value = CommsErrorWrapper.from_json(return_value)
elif buffers:
assert len(buffers) == 1
return_value = buffers[0]
content['call_return_value'] = return_value
content['call_return_value'] = return_value

# Unexpected reply
if call_id not in self._reply_waitlist: