CC-34716: Cart Reorder + Order Amendment features. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakubanov
approved these changes
Dec 2, 2024
| } | ||
| ]; | ||
|
|
||
| // Generate products dynamically |
There was a problem hiding this comment.
Minor: generate products, customers, etc would be better to move to a separate methods just for readability
There was a problem hiding this comment.
It should be reworked in next phase. For now I would keep it as it is.
helpers/summary-helper.js
Outdated
| } | ||
| } | ||
|
|
||
| function handleSummaryTesting(data) { |
There was a problem hiding this comment.
Minor:
Suggested change
| function handleSummaryTesting(data) { | |
| function _handleSummaryTesting(data) { |
As I understand it is used in this class only
| _getPaymentProviderName() { | ||
| return 'DummyPayment'; | ||
| _getPaymentProviderName(isMpPaymentProvider = true) { | ||
| return isMpPaymentProvider ? 'DummyPayment' : 'DummyPayment'; |
Comment on lines
+37
to
+42
| const customerIndex = (__VU - 1) % data.length; | ||
| const { customerEmail, quoteIds } = data[customerIndex]; | ||
| const quoteIndex = __ITER % quoteIds.length; | ||
|
|
||
| // Place an order | ||
| const checkoutResponseJson = sharedCheckoutScenario.haveOrder(customerEmail, quoteIds[quoteIndex], false); |
There was a problem hiding this comment.
It is repeated everywhere, does it make sense to move to a helper?
There was a problem hiding this comment.
If it would be a helper in AbstractScenario, this class will be a rich model with N helpers, I would avoid it. Instead of helper, we could reuse scenario methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.
Steps before you submit a PR
contribution-license-agreement.txtfile with the following content:I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/commerce-k6-performance-tests/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCHis a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist