Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add network type to domain object #321

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jan 4, 2024

Description

Added the Network Type property to the Domain object

Related Issue Or Context

Network type is required in consumers of the getDomains call to correctly implement the widget

How Has This Been Tested? Testing details.

Expanded the Domain type to also include the network type

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@FSM1 FSM1 requested review from wainola, mpetrun5 and MakMuftic January 4, 2024 15:08
@FSM1 FSM1 self-assigned this Jan 4, 2024
@FSM1 FSM1 merged commit 187dc78 into main Jan 4, 2024
3 checks passed
@FSM1 FSM1 deleted the feat/add-network-type-to-domain branch January 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants