Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add dynamic list of domains and update testnet #131

Merged
merged 10 commits into from
Feb 27, 2024

Conversation

MakMuftic
Copy link
Contributor

This PR addresses some immediate changes required on the test net environment page because of removing two networks.
It also adds the first finalized component from draft PR #128 - dynamic domain table.

Details

  • Add a dynamic list of domains inside the environment page
  • Update testnet environment
  • Remove devnet environment from the documentation

@MakMuftic MakMuftic changed the title feature: add dynamic list of domains feature: add dynamic list of domains and update testnet Feb 26, 2024
tcar121293
tcar121293 previously approved these changes Feb 26, 2024
Copy link
Contributor

@haochizzle haochizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few lines need to be updated.
we should also consider updating the docs to include instructions for _RPC_URL which now seem to be part of the .env file in the sygma-sdk examples.

Copy link
Contributor

@haochizzle haochizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@haochizzle haochizzle merged commit e41df54 into develop Feb 27, 2024
1 check passed
@haochizzle haochizzle deleted the mmuftic/add-dynamic-list-of-domains branch February 27, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants