Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a request contains multiple cookies, HTTP request snippet has multiple Cookie headers when the spec permits only one #947

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 17, 2024

This PR changes to use a single Cookie header in the HttpRequestSnippet to align with the following in RFC 6265:

When the user agent generates an HTTP request, the user agent MUST NOT attach more than one Cookie header field.

See https://www.rfc-editor.org/rfc/rfc6265#section-5.4

@wilkinsona wilkinsona changed the title Use single Cookie header in HttpRequestSnippet When a request contains multiple cookies, HTTP request snippet has multiple Cookie headers when the spec permits only one Oct 17, 2024
@wilkinsona wilkinsona added type: bug A bug and removed status: waiting-for-triage Untriaged issue labels Oct 17, 2024
@wilkinsona wilkinsona added this to the 3.0.x milestone Oct 17, 2024
@wilkinsona
Copy link
Member

Thanks very much, @izeye.

@izeye izeye deleted the cookie branch October 18, 2024 11:42
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.2 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants