Polishing.

Minor formatting and references to GH issues. See #1714 Original pull request #1963
spring-projects · Jan 16, 2025 · b51c77b · b51c77b
1 parent ea29642
commit b51c77b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java
@@ -344,6 +344,7 @@ public <T> List<T> findAll(Class<T> domainType) {
 
 	@Override
 	public <T> Stream<T> streamAll(Class<T> domainType) {
+
 		Iterable<T> items = triggerAfterConvert(accessStrategy.findAll(domainType));
 		return StreamSupport.stream(items.spliterator(), false).map(this::triggerAfterConvert);
 	}

diff --git a/...a-jdbc/src/main/java/org/springframework/data/jdbc/mybatis/MyBatisDataAccessStrategy.java b/...a-jdbc/src/main/java/org/springframework/data/jdbc/mybatis/MyBatisDataAccessStrategy.java
@@ -269,6 +269,7 @@ public <T> List<T> findAll(Class<T> domainType) {
 
 	@Override
 	public <T> Stream<T> streamAll(Class<T> domainType) {
+
 		String statement = namespace(domainType) + ".streamAll";
 		MyBatisContext parameter = new MyBatisContext(null, null, domainType, Collections.emptyMap());
 		Cursor<T> cursor = sqlSession().selectCursor(statement, parameter);
@@ -277,12 +278,14 @@ public <T> Stream<T> streamAll(Class<T> domainType) {
 
 	@Override
 	public <T> List<T> findAllById(Iterable<?> ids, Class<T> domainType) {
+
 		return sqlSession().selectList(namespace(domainType) + ".findAllById",
 				new MyBatisContext(ids, null, domainType, Collections.emptyMap()));
 	}
 
 	@Override
 	public <T> Stream<T> streamAllByIds(Iterable<?> ids, Class<T> domainType) {
+
 		String statement = namespace(domainType) + ".streamAllByIds";
 		MyBatisContext parameter = new MyBatisContext(ids, null, domainType, Collections.emptyMap());
 		Cursor<T> cursor = sqlSession().selectCursor(statement, parameter);

diff --git a/...ava/org/springframework/data/jdbc/core/AbstractJdbcAggregateTemplateIntegrationTests.java b/...ava/org/springframework/data/jdbc/core/AbstractJdbcAggregateTemplateIntegrationTests.java
@@ -389,6 +389,7 @@ void findByNonPropertySortFails() {
 
 	@Test // GH-1714
 	void findByNonPropertySortLikeStreamFails() {
+
 		assertThatThrownBy(() -> template.streamAll(LegoSet.class, Sort.by("somethingNotExistant")))
 				.isInstanceOf(InvalidPersistentPropertyPath.class);
 	}

diff --git a/...c/test/java/org/springframework/data/jdbc/mybatis/MyBatisDataAccessStrategyUnitTests.java b/...c/test/java/org/springframework/data/jdbc/mybatis/MyBatisDataAccessStrategyUnitTests.java
@@ -247,7 +247,7 @@ public void findAll() {
 				);
 	}
 
-	@Test
+	@Test // GH-1714
 	public void streamAll() {
 
 		String value = "some answer";
@@ -299,7 +299,7 @@ public void findAllById() {
 				);
 	}
 
-	@Test
+	@Test // GH-1714
 	public void streamAllByIds() {
 
 		String value = "some answer 2";
@@ -430,7 +430,7 @@ public void findAllSorted() {
 				);
 	}
 
-	@Test
+	@Test // GH-1714
 	public void streamAllSorted() {
 
 		String value = "some answer 3";