Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update SCDF-UI to use the latest APIs #2026

Closed
wants to merge 2 commits into from
Closed

Conversation

oodamien
Copy link
Contributor

Resolves #2021

@cppwfs
Copy link
Contributor

cppwfs commented Dec 10, 2024

We can remove the following bootVersions from the following:

  • app.model.ts line line 33. And the subsequent removal of code
    • detailed.app.model.ts line 84
  • api/app.service.mock.ts line 29
  • runtime-environment-details.model.ts.html line 277
  • app.html line 87,151
  • AppDeployer.html, AppPage-2.html, AppPage.html
  • AppServiceMock.html
  • Plus the comments below.

@cppwfs
Copy link
Contributor

cppwfs commented Dec 10, 2024

Kicked the tires on the following and looks good.

  • Registered app via properties
  • Registered single app.
  • Launch Task and was able to verify that task execution and task execution detail was available
  • Launch Task-Batch and was able to verify that task-execution detail was available
    • Was able to verify that Job execution, JobExecution Detail and Step Execution detail were available
  • Relaunched Task-Batch and was able to verify that data in JobExecution and StepExecution were correct for a job that had already completed
  • Created CTR Definition and was able to launch and relaunch it. All Job and execution data looked good.
  • Able to batch remove Task and Job Executions view proper results in Task and Job executions.

@cppwfs cppwfs self-requested a review December 10, 2024 22:12
Copy link
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cppwfs
Copy link
Contributor

cppwfs commented Dec 11, 2024

@oodamien Thank you for your work on this!!!

@cppwfs
Copy link
Contributor

cppwfs commented Dec 11, 2024

LGTM
Rebased Merged.

@cppwfs cppwfs closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SCDF-UI to use the latest APIs
2 participants