Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement unsubscribing from a topic. And getting current topic #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dams
Copy link
Contributor

@dams dams commented Jan 19, 2018

No description provided.

@dams
Copy link
Contributor Author

dams commented Apr 3, 2018

ping ?

@dams
Copy link
Contributor Author

dams commented Jun 1, 2018

Any progress ?

@objectuser
Copy link
Contributor

@dams This doesn't quite work. It leaves orphaned processes for the unsubscribed topic. This can be seen using :observer.

Looking more closely now.

@objectuser
Copy link
Contributor

It looks like the subscribers and workers need to be terminated, so I think this is a bit more complicated.

@dams
Copy link
Contributor Author

dams commented Jun 5, 2018

Ah that's why I also saw strange behaviours... Don't we have a hook to these subscribers and workers ?

@objectuser
Copy link
Contributor

Yes, Kaffe.GroupMember knows all the subscribers and Kaffe.WorkerManager has a table of the workers.

I'm not sure the supervision tree is optimized for shutting them down, so it might be a bit more manual.

@dams
Copy link
Contributor Author

dams commented Jun 5, 2018

I don't think it's a problem if it requires the user to write some code to properly shut down the subscribers/workers. But it would be g reat to at least document what to do when shutting down a consumer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants